Change to restarting of dead peers #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikatson
requested changes
Sep 19, 2024
Owner
ikatson
left a comment
ikatson
left a comment
There was a problem hiding this comment.
Put some comments. Also recently the e2e test was very stable, but it broke in this PR, which makes me think it has a bug
Contributor
Author
|
If you don't mind, I'll play more around this PR - remove first cancellation as it it clearly wrong now and look only on preventing retry on failed incoming peers. |
ikatson
requested changes
Sep 21, 2024
ikatson
approved these changes
Sep 21, 2024
|
|
||
| if self.incoming { | ||
| // do not retry incoming peers | ||
| debug!("incoming peer {handle} died, not re-queueing"); |
Owner
There was a problem hiding this comment.
nit: at least for the sake of consistent style please put handle into a parameter, e.g. debug!(peer=handle, "incoming peer died, not re-queueing");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while I was observing how dead peers are retried and found couple of thing, which I think are sub-optimal:
on_peer_diedis called and eventually peer is scheduled as outgoing, TheSocketAddressin this case has outgoing port of peer I think, so retry with it as outgoing does not make sense to me.This not final PR - rather a sketch to illustrate my findings. There is probably better way to solve it.