Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
サイクル概要
v0.3.0 のコードベース調査レポート(Unit 006 → Unit 008)で採否確定した 5 件のテストカバレッジ不足(#41-#45)を解消し、
bin/jailrunの重要サブコマンド(token / ruleset / aws / config)と関連 Python モジュールのテスト基盤を補強する品質補強リリース。含まれる Unit
tests/token.bats新設(tests/token.batsを新設(_cmd_add/_cmd_rotate/_cmd_delete/_cmd_listカバー) #41 -_cmd_add/_cmd_rotate/_cmd_delete/_cmd_listカバー)tests/ruleset.bats新設(tests/ruleset.batsを新設(_cmd_rulesetカバー、gh apimock) #42 -_cmd_ruleset+gh apimock)tests/aws.bats新設(tests/aws.batsを新設(_setup_aws_credentialsカバー) #43 -_setup_aws_credentials+aws stsmock)tests/test_config_cli.py新設(tests/test_config_cli.pyを新設(cmd_*関数の直接ユニットテスト、unittest 方針、CLI 経路は既存カバー) #44 -cmd_*関数の直接 unittest)tests/test_config_migrate.py新設(tests/test_config_migrate.pyを新設(shell config → TOML ラウンドトリップ) #45 - shell→TOML ラウンドトリップ)bin/jailrun --version、HISTORY.md、docs 要否判定)Closes
tests/token.batsを新設(_cmd_add/_cmd_rotate/_cmd_delete/_cmd_listカバー) #41tests/ruleset.batsを新設(_cmd_rulesetカバー、gh apimock) #42tests/aws.batsを新設(_setup_aws_credentialsカバー) #43tests/test_config_cli.pyを新設(cmd_*関数の直接ユニットテスト、unittest 方針、CLI 経路は既存カバー) #44tests/test_config_migrate.pyを新設(shell config → TOML ラウンドトリップ) #45補足
testターゲット(bats tests/+python3 -m unittest discover)を維持し、新規テストは自動的に取り込まれるv0.3.1付与と main マージを実施