Add pipefail to aws-mfa to exit on profile errors#106
Merged
Conversation
Fixes #31 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pipefailoption tobin/aws-mfaso the script exits immediately whenaws sts get-caller-identityfails (e.g., "The config profile could not be found").Why
The script pipes
aws | jq | sedon line 51. Withoutpipefail, thepipeline exit status comes from the last command (
sed), which alwayssucceeds — masking the AWS CLI error and letting the script continue with
an invalid ARN.
Verification
shellcheck bin/aws-mfapasses with no warnings.aws-mfa -p nonexistent-profile-12345and confirmed the script exits immediately with:Closes #31