ext/xsl: free libxslt buffer when transformToXml output is empty#50
Closed
ext/xsl: free libxslt buffer when transformToXml output is empty#50
Conversation
If xsltSaveResultToString sets doc_txt_ptr to a non-NULL allocation but doc_txt_len to zero, the previous gate skipped xmlFree and leaked the buffer. Current libxslt (1.1.34) sets both to NULL/0 in that case, so this is latent today; the fix removes the dependency on that convention.
Owner
Author
|
Superseded by php#21886. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xsltSaveResultToStringcan leavedoc_txt_ptrnon-NULL withdoc_txt_len == 0. The previous gateif (doc_txt_ptr && doc_txt_len)skippedxmlFreein that case. Current libxslt (1.1.34) sets both fields to NULL/0 on empty output, so this is latent today, but a future libxslt change to that convention turns it into a per-transform leak. Free the buffer whenever it's allocated, regardless of length.