Introducing option to choose methods for bayes_factor calculation#7
Merged
vp35-illinois-edu merged 3 commits intoillinois:developfrom Apr 9, 2025
Merged
Conversation
Emily-Line-UIUC
previously approved these changes
Apr 7, 2025
Collaborator
Emily-Line-UIUC
left a comment
There was a problem hiding this comment.
Overall looks good - we should talk about the draw size arguments for the draw and test method. I'm assuming that it's using the same input values as the Gibbs algorithm, but the GUI draw size label should be changed to something more generic in that case.
Collaborator
Author
Can I remove the word "Gibbs" from UI and make it just Sampling? |
Emily-Line-UIUC
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UI now looks like this with a drop-down for Bayes factor under "Type of test."