Skip to content

Introducing option to choose methods for bayes_factor calculation#7

Merged
vp35-illinois-edu merged 3 commits intoillinois:developfrom
vp35-illinois-edu:ui_changes_v2
Apr 9, 2025
Merged

Introducing option to choose methods for bayes_factor calculation#7
vp35-illinois-edu merged 3 commits intoillinois:developfrom
vp35-illinois-edu:ui_changes_v2

Conversation

@vp35-illinois-edu
Copy link
Copy Markdown
Collaborator

@vp35-illinois-edu vp35-illinois-edu commented Apr 3, 2025

  1. Renamed bayes factor 1 to bayes factor using draw and test method
  2. Renamed bayes factor 2 to bayes factor using gibbs sampler method
  3. Introduced drop-down in UI to switch
  4. Pending - May need to update "qtest_version" at Line 2115. Planning to do it in the next PR.

The UI now looks like this with a drop-down for Bayes factor under "Type of test."

image

Emily-Line-UIUC
Emily-Line-UIUC previously approved these changes Apr 7, 2025
Copy link
Copy Markdown
Collaborator

@Emily-Line-UIUC Emily-Line-UIUC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - we should talk about the draw size arguments for the draw and test method. I'm assuming that it's using the same input values as the Gibbs algorithm, but the GUI draw size label should be changed to something more generic in that case.

@vp35-illinois-edu
Copy link
Copy Markdown
Collaborator Author

Overall looks good - we should talk about the draw size arguments for the draw and test method. I'm assuming that it's using the same input values as the Gibbs algorithm, but the GUI draw size label should be changed to something more generic in that case.

Can I remove the word "Gibbs" from UI and make it just Sampling?

@vp35-illinois-edu vp35-illinois-edu marked this pull request as ready for review April 9, 2025 19:49
@vp35-illinois-edu vp35-illinois-edu merged commit db7707c into illinois:develop Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants