Merged
Conversation
- RampedParam: sample-accurate linear ramp to prevent zipper noise on real-time parameter changes (volume, cutoff, etc.) - per_track_saturate(): cubic soft-clip applied per drum voice before bus summing, adding individual punch without killing transients Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add peak envelope follower alongside RMS detector in GlueCompressor, using max(RMS, peak) for detection — catches transients RMS misses - Add parallel "crush" compressor in engine: heavily compressed copy blended at 30% for body/sustain without killing dynamics Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Kick: add sub-oscillator one octave below for chest-hitting low-end weight - Snare: add comb filter on noise path for shell resonance character, tuned to 2x snare pitch with color-controlled feedback - Hi-hats (closed + open): add bright transient noise burst (2-3ms) and high-shelf sizzle boost (~10kHz +40%) for crispness and shimmer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add 5-tap early reflection delay line (3/7/11/17/23ms) for spatial definition before the diffuse Schroeder tail - Reduce feedback ceiling from 0.92 to 0.85 for cleaner decay - Early reflections mixed slightly louder than diffuse for clarity Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Reduce kick sub-oscillator level 0.70→0.35 and shorten decay (was too boomy) - Retune all kick presets: lower volume/decay to compensate for sub energy, ease drive since per-track saturation adds punch - Retune snare presets: lower color to tame comb filter resonance, slight volume reduction - Retune hi-hat presets (closed+open): lower snap/volume since transient burst and sizzle boost add attack and brightness - Update default DrumTrackParams accordingly Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.