Fix module-level import with HardNegCollator#62
Merged
Conversation
tonywu71
added a commit
to tonywu71/colpali
that referenced
this pull request
May 27, 2026
- Add bench_lik/bench_config.yaml: tiny ColQwen2 training config (B=16, 30 steps, LoRA r=32, bf16, H100:1) for kernel A/B - Add bench_lik/bench_train.py: runner capturing per-step time, loss, and peak VRAM; writes structured JSON - Add bench_lik/sky_bench_lik.yaml: SkyPilot launch spec, pins LIK to main@6151c44 (Lq-bucketing illuin-tech#62 + SMEM model fix illuin-tech#73) - Add bench_lik/render_report.py: HTML report renderer from result JSONs - Add bench_lik/results/: post27 baseline + 6151c44 A/B result pairs - Ignore uv.lock in .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
Fixed
HardNegCollatorat module-level if and only ifdatasetsis available