Extend comparison ops to support text#13
Merged
Conversation
< > <= >= now work on both numbers and text values. VM uses a nanval_str_cmp helper for string comparison. Interpreter adds Text match arms for all four ops.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<><=>=now work on text values using lexicographic (byte) comparisonnanval_str_cmphelper in VM following the same safety pattern asnanval_equalTest plan
vm_string_comparison— tests all 4 ops with text, including equality edge casesinterpret_string_comparison— same coverage in interpreter