ci: add skills-ref validate to lint job#144
Merged
Merged
Conversation
Add the official agentskills.io reference validator (Python package, pip-installable from the agentskills repo subdirectory) to the lint job. The previous skip was over-cautious: skills-ref ships a clean pyproject.toml and installs cleanly with pip via git+https://github.com/agentskills/agentskills.git#subdirectory=skills-ref. This catches Agent Skills spec drift on every PR. Verified locally: 'skills-ref validate skills/ilo/' reports 'Valid skill: skills/ilo'. The existing npm-based skill-validate job is left in place; the two validators give cross-implementation coverage.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills-ref, pip-installable from theagentskillsreposkills-refsubdirectory) as a step inside the existinglintjob.skills-refships a cleanpyproject.tomland installs cleanly viapip install git+https://github.com/agentskills/agentskills.git#subdirectory=skills-ref.allowed-tools, optional fields).skill-validatejob is left in place; running both gives us cross-implementation coverage.Test plan
skills-ref validate skills/ilo/locally —Valid skill: skills/ilo(exit 0)cargo fmt --all -- --checkcleancargo clippy --workspace --all-targets -- -D warningscleancargo buildcleangit diff --exit-code ai.txtclean