Skip to content

ci: add skills-ref validate to lint job#144

Merged
danieljohnmorris merged 1 commit into
mainfrom
feature/skills-ref-validate-ci
May 2, 2026
Merged

ci: add skills-ref validate to lint job#144
danieljohnmorris merged 1 commit into
mainfrom
feature/skills-ref-validate-ci

Conversation

@danieljohnmorris
Copy link
Copy Markdown
Collaborator

Summary

  • Add the official agentskills.io reference validator (Python skills-ref, pip-installable from the agentskills repo skills-ref subdirectory) as a step inside the existing lint job.
  • The previous skip was over-cautious: skills-ref ships a clean pyproject.toml and installs cleanly via pip install git+https://github.com/agentskills/agentskills.git#subdirectory=skills-ref.
  • Catches Agent Skills spec drift on every PR (frontmatter shape, name format, description length, allowed-tools, optional fields).
  • The existing npm-based skill-validate job is left in place; running both gives us cross-implementation coverage.

Test plan

  • skills-ref validate skills/ilo/ locally — Valid skill: skills/ilo (exit 0)
  • cargo fmt --all -- --check clean
  • cargo clippy --workspace --all-targets -- -D warnings clean
  • cargo build clean
  • git diff --exit-code ai.txt clean
  • CI green on PR (lint job picks up the new step)

Add the official agentskills.io reference validator (Python package,
pip-installable from the agentskills repo subdirectory) to the lint
job. The previous skip was over-cautious: skills-ref ships a clean
pyproject.toml and installs cleanly with pip via
git+https://github.com/agentskills/agentskills.git#subdirectory=skills-ref.

This catches Agent Skills spec drift on every PR. Verified locally:
'skills-ref validate skills/ilo/' reports 'Valid skill: skills/ilo'.
The existing npm-based skill-validate job is left in place; the two
validators give cross-implementation coverage.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danieljohnmorris danieljohnmorris merged commit 608e550 into main May 2, 2026
5 checks passed
@danieljohnmorris danieljohnmorris deleted the feature/skills-ref-validate-ci branch May 2, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant