fix pi package peer-dep scope to @earendil-works#152
Merged
Conversation
per https://github.com/earendil-works/pi/blob/main/packages/coding-agent/docs/packages.md the supported peer deps for pi packages are: @earendil-works/pi-ai @earendil-works/pi-agent-core @earendil-works/pi-coding-agent @earendil-works/pi-tui typebox my first cut at the package used @mariozechner/* because that is the scope my locally installed pi 0.66.1 ships under. that scope is the pre-fork name. pi installs from pi.dev resolve peer deps under @earendil-works/* (currently 0.74.0), so the package as published would fail to load on a stock install. switch the type import in extensions/ilo.ts and the peerDependencies block in package.json. strict type check passes against @earendil-works/pi-coding-agent 0.74.0 unchanged - the API surface between the two scopes is compatible for the bits we use (ExtensionAPI, registerTool, the Static<typeof params> param type).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pi/extensions/ilo.tsto import from@earendil-works/pi-coding-agentpi/package.jsonpeerDependencies to the five canonical packages listed in https://github.com/earendil-works/pi/blob/main/packages/coding-agent/docs/packages.md - @earendil-works/{pi-ai,pi-agent-core,pi-coding-agent,pi-tui} and typeboxWhy
When I first wrote the package I read the type surface off my locally installed pi (0.66.1, published under
@mariozechner/*). That scope is the pre-fork name. New pi installs from pi.dev pull from@earendil-works/*(currently 0.74.0), so the package as merged in #151 would fail to resolve peer deps on a fresh install.The canonical doc explicitly lists which packages belong in peerDependencies, so this is now sourced from the upstream spec rather than my local environment.
Test plan
@earendil-works/pi-coding-agent@0.74.0with the new importsv*release;publish-pijob publishespi-ilo-langand a freshpi install npm:pi-ilo-langfrom pi.dev resolves all peer deps cleanly