verifier + interpreter + VM + cranelift: allow ! on Optional#169
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tests + example pinning mget bang behaviour across engines.
danieljohnmorris
force-pushed
the
fix/mget-bang-optional
branch
from
ba1a31f to
f879f44
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every Optional consumer in the doc hits the same friction:
mget!rejected becausemgetreturnsO _notR _ _. Now!works on Optional-returning builtins and user functions, with symmetric semantics:Some(v)yieldsv,Nilpropagates as the function's nil-return (parallel to how Result-unwrap propagates the Err variant). The verifier enforces that the enclosing return type can hold nil. Cross-engine tests + example.