builtins: add lst xs i v for list update by index#177
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danieljohnmorris
force-pushed
the
fix/list-mutation
branch
from
78f4018 to
4a17e8d
Compare
Doc cited histogram-bin updates requiring full list rebuild per increment, O(n^2) for big histograms. Added lst xs:L a i:n v:a>L a returning a new list with element at index i replaced. Value semantics preserved - original list unchanged. Negative index errors like at. Opcode 110.
danieljohnmorris
force-pushed
the
fix/list-mutation
branch
from
4a17e8d to
da6068a
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc cited histogram-bin updates requiring full list rebuild per increment, O(n²) for big histograms. Added
lst xs:L a i:n v:a>L areturning a new list with index i replaced. Value semantics preserved. Negative/non-int index errors likeat. Opcode 110. 23 cross-engine tests + histogram example.