builtins: add tan log10 log2 atan2#181
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danieljohnmorris
force-pushed
the
fix/math-extra-builtins
branch
2 times, most recently
from
8351af3 to
a1f7147
Compare
Follow-up to PR #162 math builtins. Adds the four remaining transcendentals every analysis program needs: phase angles atan2, decibels log10, bit-depth log2, oscillations tan. atan2 takes y first per C/Python convention. Opcodes 105-108.
danieljohnmorris
force-pushed
the
fix/math-extra-builtins
branch
from
a1f7147 to
583e003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #162. Adds the four remaining transcendentals every analysis program needs: phase angles
atan2, decibelslog10, bit-depthlog2, oscillationstan. atan2 takes y first per C/Python convention. Opcodes 105-108. 11 cross-engine tests + example with phase/dB/bits/slope.