builtins: add transpose matmul dot for matrix work#193
Merged
Conversation
danieljohnmorris
force-pushed
the
fix/linalg-basic
branch
from
6b2bf05 to
b2704d6
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
The token-minimal pitch only holds if numeric workloads are first class. transpose flips a 2D list of lists, matmul does standard matrix product with shape check, dot does the 1D vector inner product. All operate on list-of-list / list shapes already in use elsewhere - no new matrix type. Opcodes allocated: transpose, matmul, dot. Shape mismatches error with a clear message at runtime.
danieljohnmorris
force-pushed
the
fix/linalg-basic
branch
from
b2704d6 to
edcd5b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The token-minimal pitch only holds if numeric workloads are first class. Basic linear algebra was missing.
Implementation:
Tests: cross-engine regression tests + examples/linalg-basic.ilo with -- run: directives.