wr: type-verify csv and tsv 3-arg overloads#197
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danieljohnmorris
force-pushed
the
fix/csv-tsv-writer
branch
6 times, most recently
from
b3dfe22 to
b0ebef6
Compare
wr 'foo.csv' xs already worked for writing CSV but the 3-arg form wr 'foo.csv' headers rows that takes an explicit header row was slipping past type verification, accepting wrong shapes and erroring deep in the writer. Verifier now matches the 3-arg overloads for csv and tsv, checking headers is a list of text and rows is a list of lists before dispatch. Same for tsv.
danieljohnmorris
force-pushed
the
fix/csv-tsv-writer
branch
from
b0ebef6 to
1d43fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3-arg form wr 'foo.csv' headers rows was slipping past type verification, accepting wrong shapes and erroring deep in the writer.
Implementation:
Tests: cross-engine regression tests + examples/csv-tsv-writer.ilo with -- run: directives.