builtins: add dtfmt and dtparse for date/time#198
Merged
Conversation
danieljohnmorris
force-pushed
the
fix/datetime-builtins
branch
2 times, most recently
from
99d5611 to
a44fec8
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danieljohnmorris
force-pushed
the
fix/datetime-builtins
branch
7 times, most recently
from
fb8741b to
60896c1
Compare
Time handling was a manual mess of integer epoch arithmetic. dtfmt ts pat formats a unix timestamp as text using a strftime-style pattern. dtparse s pat reverses it, returning an integer timestamp. Opcodes allocated: dtfmt, dtparse. Both UTC for now; timezone handling is a follow-up. Parse failures error with the offending substring in the message.
danieljohnmorris
force-pushed
the
fix/datetime-builtins
branch
from
60896c1 to
f7ebaa7
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time handling was a manual mess of integer epoch arithmetic.
Implementation:
Tests: cross-engine regression tests + examples/datetime.ilo with -- run: directives.