builtins: add solve inv det via LU decomposition#199
Merged
Conversation
danieljohnmorris
force-pushed
the
fix/linalg-advanced
branch
from
2f28ba9 to
01bae95
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danieljohnmorris
force-pushed
the
fix/linalg-advanced
branch
3 times, most recently
from
b70cbf8 to
f27beed
Compare
With transpose/matmul/dot landed, the next layer of numeric work needs linear system solve, matrix inverse, and determinant. All three share an LU decomposition with partial pivoting, so the implementation is one routine plus three thin entry points. Opcodes allocated: solve, inv, det. Singular and non-square matrices error with a clear message. Numerical tolerance is fixed at 1e-12 for the singularity check.
danieljohnmorris
force-pushed
the
fix/linalg-advanced
branch
from
f27beed to
bc645db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With transpose/matmul/dot landed, the next numeric layer needs solve, inverse, determinant.
Implementation:
Tests: cross-engine regression tests + examples/linalg-advanced.ilo with -- run: directives.