tests + example: pin flat builtin contract#201
Merged
Conversation
flat existed but its depth semantics were only implicit. Adding a named regression suite and an example pins the contract: flat is one-level only (concat list of lists into a list), not recursive. Code that wants recursive flatten composes flat with itself or uses flatmap. No opcode change - just locking the existing behaviour in tests before further HOF work can drift it.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flat existed but its depth semantics were only implicit. Pinning the contract before HOF work drifts it.
Implementation:
Tests: cross-engine regression tests + examples/flat.ilo with -- run: directives.