builtins: add chunks n xs for non-overlapping splits#215
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
danieljohnmorris
force-pushed
the
fix/chunks-builtin
branch
from
8d2d596 to
b95e3be
Compare
Batching is everywhere (pagination, fixed-row CSV groups, RPC batch sizing, parallel work splits). Without a builtin, agents write index arithmetic by hand and bungle the trailing partial chunk. chunks n xs returns non-overlapping n-sized sublists; the final chunk may be shorter when len is not a multiple of n. Opcode 148 across tree, vm, cranelift. Empty in empty out, errors on n < 1.
danieljohnmorris
force-pushed
the
fix/chunks-builtin
branch
from
b95e3be to
88caee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batching is everywhere (pagination, CSV groups, RPC batch sizing, parallel work splits). Hand-rolled index arithmetic gets the trailing partial chunk wrong.
Implementation:
Tests: 24 cross-engine regression tests + examples/chunks.ilo with -- run: directives.