builtins: add clamp x lo hi#216
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Clamping a value into a range is a hot path for normalisation, UI coordinates, retry backoff caps, and any bounded numeric output. Writing min(hi, max(lo, x)) every time costs tokens and reads worse. clamp x lo hi returns lo when x < lo, hi when x > hi, else x. Opcode 149 across tree, vm, cranelift; uses a data word for the third register since the standard ABC slot only carries two operands.
danieljohnmorris
force-pushed
the
fix/clamp-builtin
branch
from
0598375 to
347e0d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clamping is a hot path for normalisation, UI coordinates, retry backoff caps, any bounded numeric output. min(hi, max(lo, x)) every time wastes tokens and reads poorly.
Implementation:
Tests: 8 cross-engine regression tests + examples/clamp.ilo with -- run: directives.