fix: verifier catches non-map first arg on multi-arg map builtins#351
Merged
Conversation
Closes the verifier hole reported by db-analyst rerun8: passing a fn ref (or other non-M type) as the first arg to a multi-arg map builtin used to pass verify and fail at runtime with ILO-R004. Now correctly surfaces ILO-T013 at verify time, matching the existing single-arg (mkeys) check.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
The verifier now catches non-map first arg before the interpreter runs, so the coverage test must accept either the new ILO-T013 verify-time error or the legacy ILO-R009 runtime error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes db-analyst rerun8 verifier hole:
mget/mset/mhas/mdelnow type-check their first arg as M at verify time, matching the existing single-argmkeyscheck.Repro
mget tg "a"wheretg : F M t npassed verify, errored ILO-R004 at runtimeTests
tests/regression_map_verifier_hole.rs