fix: cli-tasks example no longer echoes tasks.txt on save#355
Merged
Conversation
Pins the fixed-shape save helper across every engine. The buggy shape returned wrl's ~path and printed tasks.txt on every add/ done/clear; the fixed shape matches on wrl's result, returns ~"ok" on success, and propagates the error on failure. The lifecycle entrypoint exercises clear/add/add/done/load in one shot so the harness sees the file round-trip too.
Adds a callout next to the +=/mset/mdel mutation note so the save-helper shape that echoes tasks.txt on every successful mutation has a one-stop explanation, with the discard-and- return-"ok" idiom and a link to the example.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # ai.txt # skills/ilo/SKILL.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes interactive-cli rerun8 cosmetic finding.
savenow returns "ok" instead ofwrl's filename return.