Skip to content

fix: num trims leading/trailing ASCII whitespace#364

Merged
danieljohnmorris merged 6 commits into
mainfrom
fix/num-trim-whitespace
May 17, 2026
Merged

fix: num trims leading/trailing ASCII whitespace#364
danieljohnmorris merged 6 commits into
mainfrom
fix/num-trim-whitespace

Conversation

@danieljohnmorris
Copy link
Copy Markdown
Collaborator

Closes ml-engineer rerun8 CSV finding.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

❌ Patch coverage is 93.18182% with 9 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/interpreter/mod.rs 92.30% 3 Missing ⚠️
src/vm/jit_cranelift.rs 94.54% 3 Missing ⚠️
src/vm/mod.rs 92.10% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

The num-trim-whitespace.ilo example used num! (propagating unwrap)
inside functions declared >n, which ILO-T026 correctly rejects since
the enclosing fn must return R to propagate. Switching to num!!
(panic-unwrap) keeps the natural >n signatures with no R-typing
boilerplate, matching the bangbang-panic-unwrap example pattern.
@danieljohnmorris danieljohnmorris merged commit 5bc4166 into main May 17, 2026
5 checks passed
@danieljohnmorris danieljohnmorris deleted the fix/num-trim-whitespace branch May 17, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant