ILO-53: document and pin multi-statement function body chains#632
Merged
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Collaborator
Author
|
needs manual rebase (conflicts in: tests/regression_fn_body_multistep.rs) |
Collaborator
Author
|
needs manual — rebase conflict in non-doc file(s) |
hotfix(codegen/js): handle Pattern::Or, Expr::Todo, Expr::Panic
e5f792a to
d57d563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
;-separated) and brace-block{ stmt; ... }fn body forms; this PR makes that the official documented contract with a full regression gateexamples/fn-body-multistep.iloexercising bind-chain, braceless-guard early return,ret-based early return, and Result unwrap mid-body (v=call!)tests/regression_fn_body_multistep.rs— 18 cross-engine tests (VM + JIT) covering all three shapes the ticket requiresSPEC.mdFunctions section andskills/ilo/ilo-language.mdwith explicit body-form documentationCloses ILO-53.
Test plan
cargo test --test regression_fn_body_multistep— 18 tests pass (VM + JIT)cargo test --test examples— fn-body-multistep.ilo run/out annotations passcargo test --lib— 3330 lib tests clean🤖 Generated with Claude Code