generics: VM/Cranelift type-param-aware dispatch (ILO-387)#635
Merged
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Collaborator
Author
|
needs manual rebase (conflicts after partial auto-resolve in: ) |
Collaborator
Author
|
needs manual — rebase conflict in non-doc file(s) |
danieljohnmorris
force-pushed
the
feature/generics-vm-jit
branch
2 times, most recently
from
3252997 to
62f5ff1
Compare
Add explicit generic type parameters with bound constraints to ilo function signatures. The verifier now enforces cross-call-site type variable consistency and bound satisfaction, closing the soundness hole where `fn id a>a` silently accepted inconsistent types at different call sites. MVP: - Parser: `name<a:bound ...>` block after fn name; `<a>` unbounded - Bounds: any (default), comparable (n/t/b), numeric (n), text (t) - Verifier: unifies type variable bindings per call site (ILO-T044) - Backward compatible: legacy `fn x:a>a;x` style unchanged - New error codes: ILO-T044 (inconsistency/bound violation), ILO-P022 (malformed type-param block) - `examples/generics-bounded.ilo` passes on tree engine - 7 new verify tests; all 3330+ existing tests green Deferred: variance, higher-kinded types, multiple-bound conjunctions, bound inference from usage, return-type generic substitution, VM/JIT type-param-aware dispatch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Generics are erased at compile time — no boxing or unboxing occurs — so the bytecode VM and Cranelift JIT already dispatch generic functions correctly as monomorphic code. Add regression tests in vm::tests (7 VM tests) and vm::jit_cranelift (5 JIT tests) covering comparable, numeric, and unbounded (any) type-parameter bounds, exercising both numeric and text concrete types at call sites. Also documents the compile-time erasure strategy so it is clear future changes do not need dynamic dispatch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When a function has explicit type_params (e.g. `gid<a> x:a>a`), the verifier now infers the concrete return type at each call site by substituting the type-variable bindings collected from the arguments. Previously `gid 5` produced `Ty::Unknown`; it now correctly produces `Ty::Number`, enabling downstream type-checking to catch mismatches (ILO-T007) when the return value is passed to typed contexts. - Add `original_return: ast::Type` to `FuncSig` to carry the AST return type alongside the already-stored `original_params` - Add `collect_type_var_bindings` to extract bindings from compound param shapes (`L a`, `M t a`, `R a t`, etc.) - Add `subst_return_ty` to recursively substitute type-variable letters in the return type using the collected bindings - Hoist `var_bindings` out of the `if has_explicit_bounds` block so it is available for return-type substitution in all cases - Add 4 regression tests covering: number identity, text identity, type mismatch detection, and list-element extraction Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danieljohnmorris
force-pushed
the
feature/generics-vm-jit
branch
from
6e11105 to
16a7bc2
Compare
Collaborator
Author
|
mini pc is reviewing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm::tests) coveringcomparable,numeric, and unbounded (any) type-parameter bounds with both numeric and text concrete types at call sites.vm::jit_cranelift) covering the same bound kinds to lock in JIT correctness.Closes ILO-387. Extends ILO-61 (#620), builds on ILO-385 (#628).
Test plan
cargo test vm_bounded_generic— 7 tests passcargo test cranelift_bounded_generic— 5 tests passcargo test -- --skip aot_binary_size— all tests pass (aot_binary_size and cli_verbs AOT tests require a pre-builtlibilo.aand are pre-existing failures unrelated to this PR)🤖 Generated with Claude Code