Widen str to accept text input (identity passthrough)#655
Merged
Conversation
|
str now returns its argument unchanged when passed text, making it polymorphic-identity for already-stringy values. Number conversion behaviour is unchanged; non-text/non-number still raises a runtime error. Updated interpreter, VM (OP_STR), JIT helper (jit_str), and verifier (builtin_check_args + BUILTINS signature table). All three execution paths clone_rc correctly for the text passthrough branch. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danieljohnmorris
force-pushed
the
feature/str-text-identity
branch
from
4194162 to
ffa4d5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strnow accepts text as input and returns it unchanged (identity passthrough), making it polymorphic-identity for already-stringy valuesstr requires a number or text)src/interpreter/mod.rs), VM bytecode (OP_STRinsrc/vm/mod.rs), and JIT helper (jit_str). The VM path correctly callsclone_rcon the heap string for the passthrough casebuiltin_check_args) and BUILTINS signature table updated:strnow acceptst_or_nbuiltin_as_fn_tyupdated to returnUnknown -> t(polymorphic)Fixes ILO-375.
Test plan
str_text_passthrough_cross_engine—str "hello"returns"hello"across all enginesstr_text_passthrough_empty_cross_engine—str ""returns""str_number_cross_engine— existing number conversion still worksverify::builtin_str_text_passthrough— text arg no longer triggers ILO-T013verify::builtin_str_wrong_type— bool still triggers ILO-T013 with updated messagevm_str_text_passthrough— VM OP_STR returns text unchangedvm_str_non_text_non_number_type_error— VM errors on non-text/non-numberjit_str_text_passthrough— JIT helper returns text unchangedjit_str_non_number_non_text_signals_runtime_error— JIT helper errors on nil🤖 Generated with Claude Code