chore(bench): hardware standardisation for CI runner (ILO-348)#683
Merged
Conversation
…-348) - bench.yml: adds a "Collect hardware info and check baseline" step that reads /proc/cpuinfo and /proc/meminfo, seeds bench/hw-baseline.json on first run, and exits non-zero when the runner shape differs from the baseline so polluted results are never committed. - bench/run.sh: embeds cpu_model, cpu_count, mem_gb into results.json under a top-level "hardware" key; falls back to live detection on local runs when .hw-info.json is absent. - bench/results.json: back-fills hardware block for the existing baseline run (AMD EPYC 7763, 2-core, 6.8 GB — standard GitHub ubuntu-latest). - bench/hw-baseline.json: seeds the hardware baseline from that same run. - Regression check in bench.yml skips comparison when hardware changed between the two result files (belt-and-suspenders guard). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to ILO-65 / #608. Bench harness was running on whatever runner GitHub picked, making nightly numbers noisy and incomparable.
bench.ymlusesubuntu-latest(GitHub's standard 2-core / 7 GB RAM machines) and documents why it is the pinning point."hardware"block withcpu_model,cpu_count, andmem_gb./proc/cpuinfo+/proc/meminfo, seedsbench/hw-baseline.jsonon first run, and fails the job if the shape differs from the baseline. Regression comparison also skips (rather than false-positives) when the two result files were produced on different hardware.Files changed
.github/workflows/bench.ymlhw-baseline.jsonin commit patternbench/run.shhardwareblock inresults.jsonoutputbench/results.jsonhardwareblock for existing baselinebench/hw-baseline.jsonTest plan
benchworkflow manually on a standard ubuntu-latest runner — should print "Hardware matches baseline — proceeding."bench/results.jsonnow contains a"hardware"key after a runbench/hw-baseline.json, re-run — should seed a new baseline and commit itCloses ILO-348.
🤖 Generated with Claude Code