ILO-41: Filesystem-metadata builtins (fsize/mtime/isfile/isdir)#696
Merged
Conversation
|
All four fs-metadata primitives (fsize, mtime, isfile, isdir) now call env.caps.check_read() before accessing the filesystem. fsize/mtime return Err(ILO-CAP-001 ...) on a blocked path; isfile/isdir return false, consistent with their missing/perm-denied contract. Four new capability integration tests verify enforcement at the tree-interpreter backend. Closes ILO-41. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
danieljohnmorris
force-pushed
the
feature/fs-metadata-builtins
branch
from
7ce2ae9 to
6695cd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fsize,mtime,isfile,isdir) were already fully implemented across builtins, verify, interpreter, VM, and Python codegen--allow-readcap enforcement:fsize/mtimereturnErr(ILO-CAP-001 ...)on blocked paths;isfile/isdirreturnfalse(consistent with their missing/perm-denied contract)tests/capability_flags.rsWhat already existed
All four builtins were present on
mainwith full cross-engine coverage (15 regression tests passing). The only gap was cap enforcement in the interpreter tree-bridge path.Test plan
cargo test --test regression_fs_metadata— 15/15 passcargo test --test capability_flags— 19/19 pass (4 new tests added)Closes ILO-41.
🤖 Generated with Claude Code