Gleam: | alternatives in match arm patterns (ILO-411)#709
Merged
Conversation
`?x{"a"|"b":"found";_:"miss"}` now parses and executes correctly —
a single arm fires when the subject equals any of the pipe-separated
patterns. Implemented across parser, AST, VM codegen, interpreter,
formatter, Python codegen, and verifier.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pattern::Or(Vec<Pattern>)to the AST for pipe-separated match alternativesparse_match_armnow collects|-separated patterns intoPattern::OrPattern::Orby checking each alternative; matches if any hitsExample
Matches both
"a"and"b"with the same arm body. Three or more alternatives are also supported:1|2|3:"low".Test plan
vm_or_pattern_first_alt_matches— first alternative firesvm_or_pattern_second_alt_matches— second alternative firesvm_or_pattern_no_alt_matches— falls through to wildcardvm_or_pattern_three_alts— three alternatives, middle one matchesparse_match_or_pattern_two_alts— AST shape correct for 2 altsparse_match_or_pattern_three_alts— AST shape correct for 3 alts🤖 Generated with Claude Code