chore: extract 10 oversized dispatch arms (ILO-408 partial)#718
Merged
Conversation
…ial) Extracts the 10 largest inline arms from call_function into #[inline(never)] helper functions to keep the debug-build stack frame small and prevent stack-overflow on deep-recursion tests. Arms extracted: Post (207→1 lines), Chunks (139→9), Ewm (104→10), Cap/Padl/Padr (101→6), Wr (86→1), Clamp/Min/Max/Argmax/Argmin (80→8), Flt (78→22), Fmt (77→1), Grp (56→17), Uniqby (56→17). Also splits `matches!`-based multi-verb HTTP clusters (Put/Pat, Del/Hed/Opt) and rolling-window reducers (Rsum/Ravg/Rmin) into explicit per-verb `if builtin ==` guards so the check-dispatch-arms script can measure each arm individually. Helpers added: clamp_run, chunks_run, ewm_run, cap_run, padl_padr_run, wr_run, fmt_run, flt_run, grp_run, uniqby_run, post_run, put_pat_run, del_hed_opt_run, rolling_window_run, argmax_argmin_run, setops_run. Oversized arms reduced from 38 → 28. All 3373 lib tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_functioninto#[inline(never)]helper functions, reducing the debug-build stack frame to prevent stack-overflow on deep-recursion testsmatches!-based multi-verb HTTP clusters (Put/Pat, Del/Hed/Opt) and rolling-window reducers (Rsum/Ravg/Rmin) into explicit per-verbif builtin ==guards socheck-dispatch-armscan measure them individuallyclamp_run,chunks_run,ewm_run,cap_run,padl_padr_run,wr_run,fmt_run,flt_run,grp_run,uniqby_run,post_run,put_pat_run,del_hed_opt_run,rolling_window_run,argmax_argmin_run,setops_runCloses / partially addresses ILO-408.
Test plan
cargo buildsucceedscargo test --lib— 3373 passed, 0 failed./scripts/check-dispatch-arms.sh --threshold 40— 38 → 28 failures🤖 Generated with Claude Code