hotfix: pkg.rs build break + resolve_imports arity (ILO-63 followup)#730
Merged
Conversation
PR #614 (ilo add) merged with two compile errors: 1. src/pkg.rs:253 unwraps git_ref to &str, then line 260 tries to match it as Option. Remove the early unwrap; the later match at 273-276 already handles the Option correctly. 2. src/main.rs:2465 calls resolve_imports with 4 args but it takes 5 (the build_target arg was added by #643). Add the missing arg. Restores main to a clean build.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build blocker. PR #614 (ilo add) merged with two compile errors that fail the build/coverage/cross-platform jobs on every PR's CI:
src/pkg.rs:253unwrapsgit_refto&str, then line 260 matches it asOption<_>— type error. Remove the early unwrap; the later match at 273-276 already handles theOptioncorrectly.src/main.rs:2465callsresolve_importswith 4 args but it takes 5 (thebuild_targetarg was added by feat(ILO-399): modules — conditional imports via use ?<pred> #643 conditional imports). Add the missing arg.Restores main to clean build. Lint + clippy + fmt clean.