fix(ILO-472): pin flt named-predicate parity across engines#777
Merged
Conversation
Adds a cross-engine regression test for the `hmac-cookie-parser` persona shape: `flt <named-bool-helper> <L t>`. The persona reported the tree-walker engine returning the predicate's bool output instead of the filtered list, while the VM produced the correct result. The tree-walker is no longer user-selectable from the CLI (`--run-tree` / `--run` were dropped in the rerun8 cleanup, see `src/cli/args.rs:147-160`), so the original divergence is no longer reachable via `ilo run`. This test pins the surviving engines (VM default + Cranelift JIT under `--features cranelift`) on the persona's exact shape plus numeric / empty-list / all-pass / all-fail variants, and additionally pins that the named-helper and inline-lambda surfaces produce identical output per engine so the persona's workaround can't silently start lying. Closes ILO-472. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9ae97e8 to
43fa030
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Tree-walker engine is no longer reachable from the CLI (outcome A path).
The
hmac-cookie-parserpersona's repro (flt non-empty partsonL t) now produces the correct filtered list on both surviving engines:--vm(default register VM)--jit(Cranelift)--run-tree/--runwere dropped as recognised flags in the rerun8 cleanup (seesrc/cli/args.rs:147-160); the tree-walker stays in-tree only as the HOF callback runtime that VM/JIT bail to, and that path was never the broken one (VM was reported correct in the original bug). The original divergence is therefore no longer reachable viailo run.What this PR does
Adds
tests/regression_flt_named_predicate_parity.rs, a cross-engine regression suite that pinsflt <named-helper> <L t>and<L n>shapes across every CLI-selectable engine:non-empty s:t>b;>len s 0+flt non-empty partson cookie-fragment-likeL t(the original bug repro).L nvariant withis-pos.If
--features craneliftis enabled the suite runs against--vmand--jit; otherwise just--vm.Test plan
cargo test --features cranelift,http,golden --test regression_flt_named_predicate_parity— 6 passedcargo test --features cranelift,http,golden --lib— 3505 passedcargo test --features cranelift,http,golden --tests— all suites greenCloses ILO-472.
🤖 Generated with Claude Code