fix: clippy ok_or, const-fold string alloc, errors: Option<CompileError>#9
Merged
Conversation
- Replace ok_or_else with ok_or for non-lazy VmError construction (clippy) - Const-fold string Add now uses String::with_capacity + push_str instead of format! (two allocations → one), consistent with VM dispatch - Replace errors: Vec<CompileError> with first_error: Option<CompileError>; Vec implied multi-error accumulation but only the first was ever returned
This was referenced May 13, 2026
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ok_or_else→ok_orfor non-lazy struct construction (fixes clippy warning)+now usesString::with_capacity + push_strinstead offormat!, consistent with the VM dispatch path fixed in PR perf: pre-size string concatenation with String::with_capacity #6errors: Vec<CompileError>→first_error: Option<CompileError>:Vecimplied multi-error accumulation butcompile_programalways returned only the first;Optioncorrectly models the intentTest plan
cargo clippyreports zero warnings