fix(finish): fall back to GitHubService for PRs on Linear/Jira projects#983
Merged
Conversation
`il finish <pr-number>` on a Linear-configured project failed with "Issue tracker does not support pull requests" because the finish command checked `issueTracker.supportsPullRequests` to decide whether to fetch a PR. For projects that use Linear or Jira for issue tracking but GitHub as the VCS, PRs live on GitHub — not on the issue tracker. Mirror the fallback pattern already used in `start.ts`: when the configured issue tracker doesn't support PRs, fetch the PR via a locally-instantiated `GitHubService` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
il finish <pr-number>on a Linear-configured project failed withIssue tracker does not support pull requestsbecause finish guarded the PR path onissueTracker.supportsPullRequests.StartCommand: when the configured issue tracker doesn't support PRs, fetch the PR via a locally-instantiatedGitHubService.Test plan
finish.pr-workflow.test.tscover both entry points on Linear projects:il finish 4008(explicit numeric identifier detected as PR via worktree suffix)il finish --pr 4008(explicit PR flag)finishsuite passes (146/146)