Skip to content

More background colors#32

Merged
CosmicWebServices merged 5 commits intoilovecode1:masterfrom
rogersouza:background-colors
Oct 7, 2017
Merged

More background colors#32
CosmicWebServices merged 5 commits intoilovecode1:masterfrom
rogersouza:background-colors

Conversation

@rogersouza
Copy link
Copy Markdown
Contributor

@rogersouza rogersouza commented Oct 6, 2017 •
edited by CosmicWebServices
Loading

What issue(s) does this fix?

#25

Is this complete or a WIP?

Complete

Other

Let me know if you don't like the variables name or if there's something wrong. Thanks :)

@CosmicWebServices
Copy link
Copy Markdown
Member

CosmicWebServices commented Oct 6, 2017

@RogerSec Thanks for the pr... sadly there seems to be conflicts. Could you fix them and add the new colors to the readme.md chart? Thanks again!

@rogersouza
Copy link
Copy Markdown
Contributor Author

rogersouza commented Oct 6, 2017 •
edited
Loading

Oh, sorry about that. i'll fix it right now

@CosmicWebServices
Copy link
Copy Markdown
Member

CosmicWebServices commented Oct 6, 2017

No problem at all :D I can reopen the issue if you want me to...

@CosmicWebServices CosmicWebServices self-assigned this Oct 6, 2017
@CosmicWebServices
Copy link
Copy Markdown
Member

CosmicWebServices commented Oct 6, 2017

Are you working on updating the docs if not I have some time to do it myself :D Thanks again! 👍

@rogersouza
Copy link
Copy Markdown
Contributor Author

rogersouza commented Oct 6, 2017

I'm working on it :)

@rogersouza
Copy link
Copy Markdown
Contributor Author

rogersouza commented Oct 6, 2017

I'm supposed to add all the new properties on the readme.md?

@CosmicWebServices
Copy link
Copy Markdown
Member

CosmicWebServices commented Oct 6, 2017

You're awesome!

Yep! Hopefully, the chart makes sense if not I can explain it... Maybe you should add a new light background row.

@rogersouza
Copy link
Copy Markdown
Contributor Author

rogersouza commented Oct 6, 2017

One more thing:
Do you think we should change the name of the variables like 'red_bg' to 'dark_red_bg', for example? So we will have light_red_bg and dark_red_bg

@CosmicWebServices
Copy link
Copy Markdown
Member

CosmicWebServices commented Oct 6, 2017

I think they are fine for now

@rogersouza
Copy link
Copy Markdown
Contributor Author

rogersouza commented Oct 7, 2017

Am i forgetting something?

@CosmicWebServices
Copy link
Copy Markdown
Member

CosmicWebServices commented Oct 7, 2017

About to merge! Just got to wait till travis checks out

@CosmicWebServices CosmicWebServices merged commit 2de627c into ilovecode1:master Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CosmicWebServices CosmicWebServices

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rogersouza @CosmicWebServices