Merged
Conversation
CosmicWebServices
assigned
TheMonsterFromTheDeep and
joker314 and unassigned
TheMonsterFromTheDeep and
joker314
joker314
requested changes
Dec 13, 2017
Collaborator
There was a problem hiding this comment.
This code works great -- good job!
However, could you place a space after the = sign so that we can have our code consistently spaced and more easily readable. For the same reason, also remove the ; after the return statement.
But there are just cosmetic changes, I'm happy to merge even without them.
Member
Author
|
@joker314 fixed |
joker314
approved these changes
Dec 13, 2017
Collaborator
joker314
left a comment
joker314
left a comment
There was a problem hiding this comment.
Wonderful! Perfect code, ready to merge.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue(s) does this fix?
#44
Is this complete or a WIP?
Complete