Skip to content

[Refactor] PEP8 compatibility#46

Merged
CosmicWebServices merged 1 commit intoilovecode1:masterfrom
Kristinita:SashaGoddess
Jan 5, 2018
Merged

[Refactor] PEP8 compatibility#46
CosmicWebServices merged 1 commit intoilovecode1:masterfrom
Kristinita:SashaGoddess

Conversation

@Kristinita
Copy link
Copy Markdown
Contributor

1. Behavior before pull request

D:\Pyfancy-2\pyfancy>flake8 pyfancy.py
pyfancy.py:4:2: W291 trailing whitespace
pyfancy.py:19:2: W291 trailing whitespace
pyfancy.py:23:1: E302 expected 2 blank lines, found 1
pyfancy.py:25:5: E301 expected 1 blank line, found 0
pyfancy.py:32:14: E261 at least two spaces before inline comment
pyfancy.py:86:17: E231 missing whitespace after ','
pyfancy.py:87:29: E703 statement ends with a semicolon
pyfancy.py:89:1: W293 blank line contains whitespace
pyfancy.py:90:18: E231 missing whitespace after ','
pyfancy.py:95:1: W293 blank line contains whitespace
pyfancy.py:99:1: W293 blank line contains whitespace
pyfancy.py:100:5: E265 block comment should start with '# '
pyfancy.py:101:5: E265 block comment should start with '# '
pyfancy.py:102:5: E265 block comment should start with '# '
pyfancy.py:103:21: E231 missing whitespace after ','
pyfancy.py:105:39: W291 trailing whitespace
pyfancy.py:106:56: E701 multiple statements on one line (colon)
pyfancy.py:106:59: E225 missing whitespace around operator
pyfancy.py:107:80: E501 line too long (115 > 79 characters)
pyfancy.py:109:1: W293 blank line contains whitespace
pyfancy.py:128:1: W293 blank line contains whitespace
pyfancy.py:130:18: E231 missing whitespace after ','
pyfancy.py:139:47: W291 trailing whitespace
pyfancy.py:140:19: E231 missing whitespace after ','
pyfancy.py:141:14: E261 at least two spaces before inline comment
pyfancy.py:142:19: E261 at least two spaces before inline comment
pyfancy.py:145:26: E261 at least two spaces before inline comment
pyfancy.py:149:27: E261 at least two spaces before inline comment
pyfancy.py:150:26: E261 at least two spaces before inline comment
pyfancy.py:152:30: E261 at least two spaces before inline comment
pyfancy.py:158:40: E703 statement ends with a semicolon
pyfancy.py:182:1: W293 blank line contains whitespace
pyfancy.py:184:5: E303 too many blank lines (2)
pyfancy.py:185:19: E231 missing whitespace after ','
pyfancy.py:186:15: E261 at least two spaces before inline comment
pyfancy.py:187:25: E261 at least two spaces before inline comment
pyfancy.py:189:19: E261 at least two spaces before inline comment
pyfancy.py:190:23: E701 multiple statements on one line (colon)
pyfancy.py:193:80: E501 line too long (83 > 79 characters)
pyfancy.py:195:1: E302 expected 2 blank lines, found 1
pyfancy.py:195:14: E231 missing whitespace after ','
pyfancy.py:196:29: E251 unexpected spaces around keyword / parameter equals
pyfancy.py:196:31: E251 unexpected spaces around keyword / parameter equals
pyfancy.py:199:20: E231 missing whitespace after ','
pyfancy.py:199:25: E231 missing whitespace after ','
pyfancy.py:202:1: E305 expected 2 blank lines after class or function definition, found 1
pyfancy.py:203:22: E261 at least two spaces before inline comment
pyfancy.py:204:21: E231 missing whitespace after ','

2. Behavior after pull request

D:\Pyfancy-2\pyfancy>flake8 pyfancy.py

D:\Pyfancy-2\pyfancy>

3. Argumentation

I edit your code, that it will be PEP8 coding style compatible.

I use pyformat for it.

Thanks.

@CosmicWebServices
Copy link
Copy Markdown
Member

Thanks for the PR. Going to merge and add this to the pre release for the next version.

@CosmicWebServices CosmicWebServices merged commit 43f166e into ilovecode1:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants