Skip to content
This repository was archived by the owner on Jan 30, 2023. It is now read-only.

[Feature] add steps name under step#3

Merged
imaNNeo merged 9 commits into
imaNNeo:masterfrom
juliooa:feature/steps-name
Oct 19, 2018
Merged

[Feature] add steps name under step#3
imaNNeo merged 9 commits into
imaNNeo:masterfrom
juliooa:feature/steps-name

Conversation

@juliooa
Copy link
Copy Markdown
Contributor

@juliooa juliooa commented Oct 16, 2018

Thanks for this useful library, I'm using it in one of my apps. I took the opportunity of hacktoberfest to add a feature that I need on your library.

This PR adds the feature to include steps name under the circle step, like here:
screen shot 2018-10-15 at 9 43 02 pm

I also added the code for the sample app.

@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Oct 16, 2018

Hi,
I appreciate your PR and i have to say that i joined hacktoberfest too :)
I have to commit some changes on your pr, and how i do this ?
I can merge it and do my changes on my repo right?
or can you give me access to push on your repository ( in a new branch ) and merge it to this branch and finally merge with Main Repo?

@juliooa
Copy link
Copy Markdown
Contributor Author

juliooa commented Oct 16, 2018

@imaNNeoFighT I just add you as a collaborator, I hope that gives you the permissions.
If that doesn't work I can send this PR to another branch on your repo (develop for example), and then you can merge and do the changes, and when you are happy you can merge to master. Let me know what works for you. Thanks!

@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Oct 16, 2018

ok let me check it, give me some times,
for now your PR counter increased for hacktoberfest because just creation time is important, and for sure i will accept it ASAP because this is a good feature,
Thanks, Regards!

@imaNNeo
Copy link
Copy Markdown
Owner

imaNNeo commented Oct 18, 2018

Hi dude,
please accept my merge request on your repo, then i will merge it.
@juliooa

@juliooa
Copy link
Copy Markdown
Contributor Author

juliooa commented Oct 18, 2018

@imaNNeoFighT done!

@imaNNeo imaNNeo merged commit 3fd1a46 into imaNNeo:master Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants