Allow lenient validation in BMP decoder#2764
Merged
197g merged 6 commits intoimage-rs:mainfrom Feb 12, 2026
Merged
Conversation
telecos
force-pushed
the
feature/lenient-validation
branch
from
a276d79 to
3c9d4a2
Compare
anforowicz
approved these changes
Feb 11, 2026
telecos
force-pushed
the
feature/lenient-validation
branch
from
186dff8 to
78eb4cd
Compare
anforowicz
approved these changes
Feb 12, 2026
197g
approved these changes
Feb 12, 2026
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
Good approach of having lenient separately to really test the mode while preserving existing bad_bmp test. LGTM.
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium decoder accept certain files which are not valid per strict BMP spec. This change is introduce a lenient mode to allow these files only when lenient mode is enabled, while Strict mode is still default mode.
This change should implement discrepancies 3, 4, 5 and 6 from #2747