feature: Add drain_key_if and remove_key_if#2
Merged
imartayan merged 4 commits intoimartayan:mainfrom Jun 24, 2025
Merged
Conversation
Owner
|
Hello @shanecelis, thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the excellent crate. It's a perfect fit for what I wanted.
I added two functions
drain_key_ifandremove_key_ifthat I needed.In making those work I also added an
ExhaustIterbehind the scenes that consumes an iterator even when it's dropped prematurely. Perhaps that's controversial. If you don't want that, let me know and I'll take it out.Thank you for the crate!