[ARCHIVE] full color surface (pre-trim) — revival candidate for #19#20
Closed
lilith wants to merge 1 commit into
Closed
[ARCHIVE] full color surface (pre-trim) — revival candidate for #19#20lilith wants to merge 1 commit into
lilith wants to merge 1 commit into
Conversation
…ons + warnings notes (revival candidate)
Member
Author
|
Superseded by #21 — the full color surface this archived is the design now (full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARCHIVE / DO NOT MERGE. Draft preserving the full pre-trim color surface in case we want it back (≈1 week horizon).
The shipping version is #19 (
feat/color-signaling), which trimmed this down to the minimal surface current transcode needs. This branch keeps everything that #19 removed, so it can be cherry-picked/revived without re-deriving it:ColorPlanwith the full field set:range: Option<SignalRange>,rendering_intent: Option<RenderingIntent>,hdr_static: HdrStaticDisposition,gain_map: GainMapDisposition,notes: Vec<ColorNote>(vs feat(color): minimal cross-codec CICP/ICC emission policy #19's{cicp, icc}).GainMapDisposition { None, Rewrap, DropKeepSdrBase, ApplyToRecoverSdr },HdrStaticDisposition { Keep, DropForSdr },RenderingIntent(+from_code),ColorNote(5 variants).read_icc_intenthelper and the richerresolve_color_emitbody that populates range/intent and pushes the warnings notes.Revive when a consumer lands for any of: the encode-side warnings channel (
notes), gain-map/HDR dispositions, or signal-range/rendering-intent carry. BecauseColorPlanis#[non_exhaustive], these re-land as a non-breaking minor bump on top of #19.Diff = #19's 5 files but with the full 505-line
color.rs.