Skip to content

Rename framework type from cargo to nextest in TOML configs#115

Merged
DanverImbue merged 2 commits intomainfrom
nextest-rename
Mar 18, 2026
Merged

Rename framework type from cargo to nextest in TOML configs#115
DanverImbue merged 2 commits intomainfrom
nextest-rename

Conversation

@jsk11235
Copy link
Collaborator

Summary

  • Rename type = "cargo" to type = "nextest" in the three offload-cargo-*.toml config files
  • Add #[serde(rename = "nextest")] to the Cargo variant in FrameworkConfig so TOML deserialization accepts the new name
  • Update the corresponding test TOML literal in schema.rs

Test plan

  • cargo fmt --check passes
  • cargo clippy passes (no warnings)
  • cargo nextest run passes (128/128 tests)

🤖 Generated with Claude Code

Update the three offload-cargo TOML files to use type = "nextest"
and add a serde rename attribute so the Cargo variant deserializes
from the new name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link

Vet found 1 issue.


README.md:204

[documentation_implementation_mismatch] (severity 3/5) (confidence 0.90)

The README.md references to the framework type cargo are inconsistent with the rename to nextest. The CLI Reference for offload init lists cargo as a valid --framework TYPE option, and the Configuration Reference / Example Configurations sections show type = "cargo". All of these should be updated to nextest to match the new config schema.

Update user-facing string literals in main.rs so the CLI accepts
and displays "nextest" instead of "cargo" as the framework name.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link

Vet found 1 issue.


README.md:376

[documentation_implementation_mismatch] (severity 3/5) (confidence 0.95)

The README.md contains example configuration snippets that still use type = "cargo" instead of the new type = "nextest". For example, the 'Local Cargo Tests' and 'Cargo Tests on Modal' examples show type = "cargo" in the [framework] section. These should be updated to type = "nextest" to match the rename applied to the offload-cargo-*.toml config files.

@DanverImbue DanverImbue self-requested a review March 18, 2026 18:37
Copy link
Collaborator

@DanverImbue DanverImbue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanverImbue DanverImbue merged commit ca0f7eb into main Mar 18, 2026
4 checks passed
@DanverImbue DanverImbue deleted the nextest-rename branch March 18, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants