Add RandomAccessiblePair randomAccess test #31
Conversation
hanslovsky
left a comment
hanslovsky
left a comment
There was a problem hiding this comment.
A list of small modifications that improve readability.
| Img< ByteType > in = new ArrayImgFactory< ByteType >().create( new FinalDimensions( 3, 3 ), new ByteType() ); | ||
| OutOfBoundsFactory< ByteType, RandomAccessibleInterval< ByteType > > outOfBoundsFactory = | ||
| new OutOfBoundsBorderFactory<>(); | ||
| RandomAccessibleInterval< ByteType > extendedIn = Views.interval( Views.extend( in, outOfBoundsFactory ), in ); |
There was a problem hiding this comment.
Please use Views.extendBorder instead of creating a separate factory.
| RandomAccessibleInterval< ByteType > extendedIn = Views.interval( Views.extend( in, outOfBoundsFactory ), in ); | ||
|
|
||
| // Create RandomAccessiblePair | ||
| final RandomAccessible< Neighborhood< ByteType > > safe = new RectangleShape( 1, |
There was a problem hiding this comment.
1, should be in a new line like this (with appropriate indentation):
... = new RectangleShape(
1,
false )There was a problem hiding this comment.
@hanslovsky I have added an additional comment in the opening line so that the formatter doesn't try to move the 1 to the first line every time it's run. Let me know if I should remove it or keep it that way...
There was a problem hiding this comment.
That's interesting. Are you using eclipse? I have noticed that the eclipse formatter is not always consistent among different machines (probably dependent on what settings are being used). I think the comment is fine here.
There was a problem hiding this comment.
I was using Eclipse Neon on macOS with a weird configuration (that I don't have a clue where I got it from) instead of the imglib2-eclipse-mars-clean-up-formatter-style.xml. Sorry for the confusion!
| RandomAccessible< Pair< Neighborhood< ByteType >, ByteType > > pair = Views.pair( safe, extendedIn ); | ||
|
|
||
| // Set position out of bounds | ||
| RandomAccess< Pair< Neighborhood< ByteType >, ByteType > > randomAccess = pair |
There was a problem hiding this comment.
No need for line break here (there are longer lines in this file).
stelfrich
force-pushed
the
randomaccessiblepair-test
branch
from
4350648 to
8ac641e
Compare
|
Thanks for looking at this @hanslovsky! I have added a comment to one of yours for your review. |
2 participants
Adds a test that fails prior to #30.