-
Notifications
You must be signed in to change notification settings - Fork 6
Add flip option support
#73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the flip option to imgproxy-js-core, allowing users to flip images horizontally and/or vertically. The implementation follows the established patterns used by other boolean-like options in the codebase.
Key Changes:
- Adds flip option type definitions with support for boolean-like values (
true,false,1,0,"t","f") - Implements flip option builder that generates the
fl:horizontal:verticalURL format - Includes comprehensive test coverage for various value types and edge cases
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/types/flip.ts |
Defines FlipOptions type and FlipOptionsPartial interface with horizontal/vertical properties supporting boolean-like values |
src/options/flip.ts |
Implements test and build functions for flip option, including shorthand fl support |
tests/optionsBasic/flip.test.ts |
Comprehensive test suite covering various input types, defaults, and both flip/fl shorthands |
src/types/index.ts |
Integrates FlipOptionsPartial into the main Options type |
src/options/index.ts |
Exports flip module for public API access |
.changeset/brown-mangos-fetch.md |
Documents the feature addition as a minor version change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #66