Adds expires to supported options#181
Merged
DarthSim merged 2 commits intoimgproxy:masterfrom Jun 14, 2022
Merged
Conversation
Member
|
Hi Ross! There's no need for an additional test. Just add the |
Contributor
Author
|
I tried that first, but I ran into an issue that I assumed was related to needing signed urls for expiration, but now I think I was just missing a |
Ross-Hunter
commented
Jun 9, 2022
| auto_rotate: true, | ||
| filename: "the_image.jpg", | ||
| format: :webp, | ||
| expires: Time.at(4810374983), |
Contributor
Author
There was a problem hiding this comment.
100 years from now seems like a safe number here.
DarthSim
force-pushed
the
feature/expires
branch
from
c167280 to
e357697
Compare
Member
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started working on this because I didn't realize that you can just pass through parameters that aren't explicitly parsed by this library, but the benefit of this PR is that it allows using Time objects directly instead of needing to convert to an integer. It also now explicitly says in the README that
expiresis supported.