[Feature] Better ways to create new face tag/update face tag #28513
EmberLightVFX
started this conversation in
Feature Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I have searched the existing feature requests, both open and closed, to make sure this is not a duplicate request.
The feature
I have a bunch of photos that the machine learning didn't catch (eg. face too small in image, back of head showing only) or photos of pets that didn't get a match ether.
I made a PR that allows me to simply ctrl+drag to create a new face tag. I also made a companion PR that lets me ctrl+click on an already existing tag to quickly be able to change what face has bin tagged.
Before I had to go
(+) -> drag the tag-square to the correct position -> resize to fit the face -> enter the person.After the PR I simply
ctrl+drag -> enter the person.It saves a lot of clicks over many photos.
drag.mp4
And to edit a tag I had to go
Edit People -> Seach for the wrongly tagged face if there is many tagged -> Select new face -> Pick new face. After we can now simplyctrl+click on the face on the picture -> Select new faceclick.mp4
I'm a python and c++ dev and not that familiar with svelte so I used Claude to help me structure the code but I did manual review of the code and updated parts that wasn't needed, made them more clean and more logical.
I'm super grateful that @danieldietzler took a look at it even with the Claude help but the svelte code wasn't up to par so the PRs got closed.
I think these features would be a great UX update to Immich but I would also love to know other peoples thought on this kind of feature.
If anyone that knows Svelte better than me want to take a stab at it you have my closed PRs here:
ctrl+drag to create person tag: #28386ctrl+click to select new face on tag: #28425Cheers!
Platform
All reactions