feat: Support config via Systemd Credentials #17211
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://systemd.io/CREDENTIALS/. This is used as a fallback, so will only be used if the `$*_FILE` var is empty. This could also be used to implicitly use Docker Secrets by settings `CREDENTIALS_DIRECTORY=/run/secrets` rather than setting individual `$_*FILE` environment variables.
github-actions
bot
added
the
documentation
Member
|
Can you rebase this against main please? |
jrasm91
approved these changes
Jun 12, 2025
Member
|
Hey @amarshall could you please rebase the PR or allow editing for contributors? |
Member
|
I'm just going to close it. If they make the changes they can open it again. |
8 tasks
Contributor
Author
|
Reopened as #20406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://systemd.io/CREDENTIALS/. This is used as a fallback, so will only be used if the
$*_FILEvar is empty. This could also be used to implicitly use Docker Secrets by settingsCREDENTIALS_DIRECTORY=/run/secretsrather than setting individual$_*FILEenvironment variables.How Has This Been Tested?
I patched Immich using this change and tested the functionality.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)