-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore(Dockerfile): add metadata labels to define source #17355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I would prefer if this was set from the docker/metadata-action output in the build workflow (eg at https://github.com/immich-app/immich/blob/main/.github/workflows/docker.yml#L419). |
|
I have not been aware of that action. Changed the an approach which only modifies the action input. |
|
Sorry, I should have been clearer. That action already outputs appropriate labels, but the next step doesn't currently apply them. |
|
Sry for the chatter, but I have a hard time read your CI setup. 😅 I had to switch to annotations as |
We do, but those don't carry through into the merged manifest.
I briefly looked into this, but I don't think it has a way to express the merging that we do, right? |
|
The merge jobs are failing as you can see here: https://github.com/immich-app/immich/actions/runs/14262939935/job/39978651017?pr=17378 |
As I understand you mean with merging simply publishing to different images registries, correct? So GHCR.io and Docker hub. Take a look a this example Immich server, machine-learning and such would the equivalent to |
No, I mean the |
|
After a lot of pain I fixed this in #17378. Closing this PR in favor of that one |
Description
Adds OCI metadata labels to the server and machine-learning docker images.
This allows to find the source github repository based on the OCI / Docker image, which in turn allows tools like Renovate to find changelogs for example
How Has This Been Tested?
No test run
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)