Added server-wide public albums #17429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… components - Introduced `isPublicInInstance` boolean field in the album schema and database. - Updated API specifications, TypeScript types, and DTOs to include the new field. - Enhanced album sharing functionality in the UI with a new modal for managing shared users and public visibility. - Modified access control logic to consider the public visibility of albums. - Added migration script to alter the albums table for the new field.
Member
|
We talked about this internally, and we decided the way we want to implement something like this is with user groups. We can have an "everyone" user group" and sharing an album with that group would be equivalent to what this PR is trying to enable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a feature to share album with whole server at once without need to create share link or manually add people to access list. Albums marked as
isPublicInInstancewill be visible as shared to everyone in the serverHow Has This Been Tested?
Manually tested
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)