Skip to content

Conversation

@janexner
Copy link

…NOT_EXPORTED_PERMISSION

Description

The Android mobile app comes with an unnecessary permission. My change removes that permission.

Fixes #17587

How Has This Been Tested?

None, but I am using the same in my apps.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services/ uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services/)

@github-actions
Copy link
Contributor

Label error. Requires exactly 1 of: changelog:.*. Found: . A maintainer will add the required label.

@janexner janexner changed the title Removing unnecessary permission app.alextran.immich.DYNAMIC_RECEIVER_… (fix) (mobile) Removing unnecessary permission app.alextran.immich.DYNAMIC_RECEIVER_… Apr 14, 2025
@shenlong-tanwen
Copy link
Member

@janexner Thanks a lot for the PR. We do not use any receivers but I believe few of our dependencies do. And connectivity_plus register a receiver in their native code. There is also an issue there to track this. So probably a good idea to fix this upstream

@janexner
Copy link
Author

That makes sense. I guess this PR can only be useful once upstream has been fixed, if it is.

It's really a cosmetic issue, and only really visible on F-Droid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mobile][android] Unnecessary permission app.alextran.immich.DYNAMIC_RECEIVER_NOT_EXPORTED_PERMISSION

3 participants